ESLint v9 backwards-compatible support #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckwards-compatibility.
…d ESLint versions.
This was referenced Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell from all of test tests, this PR brings
eslint-plugin-solidup to speed with the breaking changes in ESLint v9, while retaining backwards compatibility with ESLint down to at least v6.The backwards compatibility was for the most part, building helper functions in
compat.tsto bridge the gaps between different versions of thecontextobject. Setting up tests that covered both legacy and flat config and dealt with type issues was harder.Major changes: