Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and typos #953

Merged
merged 42 commits into from
Dec 3, 2024
Merged

Conversation

Hasan-Mir
Copy link
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR fixes some grammar and typo issues.

Related issues & labels

  • Closes #
  • Suggested label(s) (optional):

Copy link

stackblitz bot commented Nov 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit c0f0fd4
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/674f44e615a0cf000824ee1c
😎 Deploy Preview https://deploy-preview-953--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! Thanks 🏆

@atilafassina atilafassina added the automerge a hint for kodiak bot that this PR is ready to be merged. label Nov 21, 2024
Copy link
Contributor

kodiakhq bot commented Nov 21, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge a hint for kodiak bot that this PR is ready to be merged. label Nov 21, 2024
@atilafassina atilafassina enabled auto-merge (squash) November 21, 2024 09:46
@Hasan-Mir Hasan-Mir disabled auto-merge November 21, 2024 13:34
@Hasan-Mir Hasan-Mir marked this pull request as draft November 21, 2024 13:35
@atilafassina atilafassina self-requested a review November 21, 2024 14:53
Hasan-Mir and others added 3 commits November 22, 2024 22:16
Co-authored-by: Sarah <gerrardsarah@gmail.com>
Co-authored-by: Sarah <gerrardsarah@gmail.com>
@Hasan-Mir Hasan-Mir marked this pull request as ready for review November 22, 2024 18:49
@LadyBluenotes LadyBluenotes enabled auto-merge (squash) November 24, 2024 04:48
@LadyBluenotes LadyBluenotes enabled auto-merge (squash) November 24, 2024 04:48
@LadyBluenotes LadyBluenotes requested review from atilafassina and removed request for atilafassina November 24, 2024 04:51
Copy link
Contributor

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nice little fixes here. I disagree with a couple, though, and have left suggestions.

auto-merge was automatically disabled November 26, 2024 05:01

Head branch was pushed to by a user without write access

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) December 1, 2024 02:05
@LadyBluenotes LadyBluenotes merged commit 984904b into solidjs:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants