Skip to content

Conversation

@AlexErrant
Copy link
Contributor

SearchParams is on Location which is already exported. This PR makes it so I don't have to do Location['query'], e.g.

import { type Location } from '@solidjs/router'

export const someFn = (search: Location['query']) => { ... }

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: ac97470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ngdangtu-vn
Copy link
Contributor

Just what I plan to do, thanks mate.

@birkskyum
Copy link
Member

@AlexErrant can you add a changeset? pnpm changeset

@ryansolid ryansolid merged commit 30f0866 into solidjs:main Apr 25, 2025
1 check passed
@AlexErrant AlexErrant deleted the SearchParams branch April 25, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants