Merge pull request #1282 from AirBorne04/main

fix edge runtime errors reading formData and jsonData from request body
solidjs · Jan 24, 2024 · c4de61d · c4de61d
2 parents 24a4eb2 + 92e8f8f
commit c4de61d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/.changeset/neat-apricots-try.md b/.changeset/neat-apricots-try.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+fix formData and action issue for cloud runtimes
diff --git a/packages/start/config/server-handler.js b/packages/start/config/server-handler.js
@@ -92,9 +92,18 @@ async function handleServerFunction(h3Event) {
       contentType.startsWith("multipart/form-data") ||
       contentType.startsWith("application/x-www-form-urlencoded")
     ) {
-      parsed.push(await request.formData());
+      // workaround for https://github.com/unjs/nitro/issues/1721
+      // (issue only in edge runtimes)
+      parsed.push(await new Request(request, { ...request, body: event.node.req.body }).formData());
+      // what should work when #1721 is fixed 
+      // parsed.push(await request.formData);
     } else {
-      parsed = fromJSON(await request.json(), {
+      // workaround for https://github.com/unjs/nitro/issues/1721
+      // (issue only in edge runtimes)
+      const tmpReq = new Request(request, { ...request, body: event.node.req.body })
+      // what should work when #1721 is fixed
+      // just use request.json() here
+      parsed = fromJSON(await tmpReq.json(), {
         plugins: [
           CustomEventPlugin,
           DOMExceptionPlugin,