Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: getServerFunctionMeta creates circular import #1772

Closed
2 tasks done
katywings opened this issue Feb 6, 2025 · 0 comments · Fixed by #1773
Closed
2 tasks done

[Bug]: getServerFunctionMeta creates circular import #1772

katywings opened this issue Feb 6, 2025 · 0 comments · Fixed by #1773
Assignees
Labels
bug Something isn't working

Comments

@katywings
Copy link
Contributor

katywings commented Feb 6, 2025

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

If you import getServerFunctionMeta from @solidjs/start/server in a file related to a route, this creates a circular import, because StartServer also resides in @solidjs/start/server. Most of the time vite seems to be able to prevent this from breaking the app. But in some cases (especially during vite dev) it fails and the circular import will lead to getServerFunctionMeta being undefined.

Expected behavior 🤔

You should be able to import getServerFunctionMeta without introducing a circular import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant