Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests to run on node 20.x #1085

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Oct 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Tests fail on Node 20.x

What is the new behavior?

Tests pass on Node 20.x

Other information

Updated @playwright/test to 1.38.1. Fixes #1058

@ryansolid ryansolid merged commit fd2164f into solidjs:main Oct 17, 2023
9 checks passed
@edivados edivados deleted the fix-node-20-tests branch October 17, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Tests for Node 20 are Broken
2 participants