Set HttpStatusCode 500 in ErrorBoundary

[frenzzy]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• infrastructure changes
• Other... Please describe:

What is the current behavior?

In case of errors response status code is 200 OK

What is the new behavior?

In case of errors response status code is 500 Internal Server Error

Other information

[frenzzy]

With some space between error message and retry button looks prettier

[ryansolid]

I actually changed all these styles to strings intentionally to reduce compiled size output.

[frenzzy]

Changed back to string.
I just thought styles are compiled to string during the build time...

[lxsmnsyc]

I cannot agree to this because some errors can be intentional, and some unintentional. Not sure what others think.

[frenzzy]

Yes, but for intentional errors, you'll likely create a custom ErrorBoundary to suit your specific needs. For instance, you might not want to display the stack trace for these errors, and you'll want the error message to match the style of your site.

Alternatively, we could add support for customizing the status code. For example:

- <HttpStatusCode code={500} />
+ <HttpStatusCode code={props.error.statusCode ?? 500} />

However, I believe that defaulting to a 500 status code in error scenarios is generally better, as it's a widely accepted standard in web development.

[nksaraf]

I think it's reasonable the the default ErrorBoundary has this as the default. Its more web friendly and better overall for keeping up the semantics. I do agree that it should be trivial to override with your own ErrorBoundary (which people should be encouraged to know anyway)

[ryansolid]

I think the intent here is now captured with the new dev overlay and default errorboundary. So while I won't be merging this. It is getting in.

[frenzzy]

Am I correct in understanding that by default, SolidStrat will not alter response status codes in the case of errors, since the primary audience for the default ErrorBoundary is developers, and it is designed to be most visible to them? In other words, are developers always expected to create their own ErrorBoundary to override the default behavior?

Would it be useful if the default ErrorBoundary displayed a message to suggest this practice?

Also, is there a possibility to tree shake away the default ErrorBoundary when a custom one is used?