fix(dev-overlay): Code view breaking if the file extension was mjs or cjs #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e1fd48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you |
ryansolid
added a commit
that referenced
this pull request
Mar 8, 2024
* transparent errors and support http status forwarding in server fns * fix FS router circular dep by moving import * update config to anticipate Vite updates, clearer experimental features, routesDir * feat: implement getServerFunctionMeta Refs: nksaraf/vinxi#51 * add serverFunctionMeta * update Vinxi and Solid Router * fix #1366 islands mode reference * Update middleware.mdx (#1367) See https://github.com/solidjs/solid-start/blob/main/packages/start/config/index.d.ts#L11 * fix types for latest updates * don't import app on server for SSR false when SingleFlight false * fix(dev-overlay): Code view breaking if the file extension was mjs or cjs (#1368) * fix(dev-overlay): Code view breaking if the file extension was mjs or cjs * chore: add missing changeset * add `.` notation to escape layouts in FS routes * add back different content type parsing in case middleware etc.. * remove support for event symbol autoforwarding * update docs * fix: script invocation error for "create-solid@latest" (#1369) * More docs updates * remove solid-start-mdx from changeset * revert vite alignment until we know more, add server option to types --------- Co-authored-by: Katja Lutz <mail@katjalutz.ch> Co-authored-by: Feynman Liang <feynman.liang@gmail.com> Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com> Co-authored-by: Arunava Ghosh <arnvgh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a library used plain MJS for their code, or just plain CJS it ended up being
that the code view in the development overlay would not recognize the file type because
Shiki expects
mjsandcjsto be passed into it as JavaScript.What is the new behavior?
Before actually passing in the language to the highlighter it checks if the file extension is
mjsorcjsand then assumes the language isjsinstead.