fix: dont use node request as body in handleServerFunction #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1000be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
katywings
changed the title
2 tasks
|
Thanks. Hacks on hacks here until I guess we can get the right resolution from Nitro. I was concerned to merge that PR but it had been sitting for months. I tested all the local apps like Notes/TodoMVC and deployed my hackernews to Netlify and didn't see any problems. Given this breaks Node I need to move on this faster I think and we can worry about Azure if a new issue comes up. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The changes from #1521 broke the form parsing in Node, it threw the error
[h3] [unhandled] TypeError: Response body object should not be disturbed or locked.What is the new behavior?
This fixes the handling for Node, yet tries to keep the functional aspects from the edge runtime workarounds #1282 and #1521. I couldn't test this fix on edge runtimes - @supersoniko could you maybe check if your azure preset still works after this fix☺️ ?