Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always render doctype #737

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix: always render doctype #737

merged 2 commits into from
Feb 10, 2023

Conversation

seeplusplus
Copy link
Contributor

Fixes #731.

Unsure if this is the preferred way to solve this problem, as I don't have much knowledge in this codebase. I tested by making this change in the node_modules of a project I'm working on, but I was unable to follow the steps in the CONTRIBUTING.md to test.

More than happy to test, but currently getting:

~/github/solid-start$ pnpm --filter example-hackernews run dev

> example-hackernews@ dev github/solid-start/examples/hackernews
> solid-start dev

 solid-start dev 
 version  0.2.20
failed to load config from github/solid-start/examples/hackernews/vite.config.ts
node:internal/errors:478
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /github/solid-start/packages/start/fs-router/fileRoutesImport.ts
    at new NodeError (node:internal/errors:387:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:75:11)
    at defaultGetFormat (node:internal/modules/esm/get_format:117:38)
    at defaultLoad (node:internal/modules/esm/load:81:20)
    at nextLoad (node:internal/modules/esm/loader:163:28)
    at ESMLoader.load (node:internal/modules/esm/loader:605:26)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:457:22)
    at new ModuleJob (node:internal/modules/esm/module_job:63:26)
    at ESMLoader.#createModuleJob (node:internal/modules/esm/loader:480:17)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:434:34) {
  code: 'ERR_UNKNOWN_FILE_EXTENSION'
}
/github/solid-start/examples/hackernews:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  example-hackernews@ dev: `solid-start dev`
Exit status 1```

@ryansolid
Copy link
Member

ryansolid commented Feb 10, 2023

Yeah I'm getting this too.. recent PR(#709) I just merged.. it passed the test but can't build anything local. I will revert for now.

@ryansolid ryansolid merged commit be97acf into solidjs:main Feb 10, 2023
@ryansolid
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCTYPE not set when ssr is disabled
2 participants