add more tests

solidjs · Oct 1, 2024 · ef8f62a · ef8f62a
1 parent ab424d5
commit ef8f62a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -884,8 +884,8 @@ export function untrack<T>(fn: Accessor<T>): T {
 export type ReturnTypes<T> = T extends readonly Accessor<unknown>[]
   ? { [K in keyof T]: T[K] extends Accessor<infer I> ? I : never }
   : T extends Accessor<infer I>
-    ? I
-    : never;
+  ? I
+  : never;
 
 // transforms a tuple to a tuple of accessors in a way that allows generics to be inferred
 export type AccessorArray<T> = [...Extract<{ [K in keyof T]: Accessor<T[K]> }, readonly unknown[]>];

diff --git a/packages/solid/test/signals.type-tests.ts b/packages/solid/test/signals.type-tests.ts
@@ -887,11 +887,13 @@ interface KobalteBaseSelectProps<Option, OptGroup = never> {
 interface KobaltSingleSelectProps<T> {
   value?: T | null;
   onChange?: (value: T) => void;
+  multiple?: false;
 }
 
 interface KobaltMultiSelectProps<T> {
   value?: T[];
   onChange?: (value: T[]) => void;
+  multiple?: true;
 }
 
 type KobaltSelectProps<Option, OptGroup = never> = (
@@ -903,8 +905,15 @@ type KobaltSelectProps<Option, OptGroup = never> = (
 type fruits = "apple" | "banana" | "orange";
 const fruits: fruits[] = ["apple", "banana", "orange"];
 const [fruit, setFruit] = createSignal<fruits>("apple");
+const [fruitArr, setFruitArr] = createSignal<fruits[]>(["apple"]);
 function kobalteSelect<T>(props: KobaltSelectProps<T>) {}
 kobalteSelect({ value: fruit(), onChange: setFruit, options: fruits });
+kobalteSelect<fruits>({
+  value: fruitArr(),
+  onChange: setFruitArr,
+  options: fruits,
+  multiple: true
+});
 
 //////////////////////////////////////////////////////////////////////////
 // test explicit generic args ////////////////////////////////////////////