Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in NPM documentation #2263

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

miabrahams
Copy link
Contributor

Link to Github pages for JS Framework Benchmark and hope-ui

Summary

Hello! I was checking out Solid on npmjs.com and noticed a broken link to the performance benchmark. I clicked through the rest of the links in README.md and found hope-ui.com had also been taken down. I replaced the benchmark link with a github.io site that was used elsewhere and the hope-ui link to the Github repo.

How did you test this change?

I opened the VS Code preview and clicked the updated links.

Link to Github pages for JS Framework Benchmark and hope-ui
Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 53f4e4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit f8ae663 into solidjs:main Aug 27, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10584336852

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.372%

Totals Coverage Status
Change from base Build 10377200163: 0.0%
Covered Lines: 4194
Relevant Lines: 4427

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants