Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 5.7 typescript doesn't like comparing strings for truthiness
And inlining
"_SOLID_DEV_" as any as boolean
doesn't seem to do the trick.So I've added a constant and use it in place of strings which silences the errors.
The output looks almost identical to using strings directly - most code paths behind a dev check get removed in prod entries. Some uncleaned if statements remain, but as they did with strings before.
The variable is not exported outside of the module, just internally between files to not redeclare it in every file.
Other option would be to use
@ts-expect-error
everywhere but that just seem a bit noisy.Also had to add some additional assertions
!
to variable declarations for refs, as they are "being used before assigned" from ts point of view.