Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade compatibility with Vite 5 #126

Closed
nilshelmig opened this issue Nov 17, 2023 · 3 comments · Fixed by #127
Closed

Upgrade compatibility with Vite 5 #126

nilshelmig opened this issue Nov 17, 2023 · 3 comments · Fixed by #127

Comments

@nilshelmig
Copy link

Vite 5 got released and this plugin is missing compatibility with the version 5.

From first look, it seems like everything should work with version 5 and only the peer dependency needs to be added. For more information there is the migration guide

@nilshelmig
Copy link
Author

Possibly relates to solidjs/solid-start#1123

@benash
Copy link

benash commented Nov 21, 2023

It looks like that linked PR will fix this. In the meantime, people can run an older version of Vite, e.g.:

npm create vite@4.4.1

@codylindley
Copy link

This will work until then in your package.json

...
    "overrides": {
        "vite-plugin-solid": {
            "vite": "^5.0.0"
        }
    },
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants