Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Vite 5 support #261

Merged
merged 5 commits into from
Dec 6, 2023
Merged

feat!: Vite 5 support #261

merged 5 commits into from
Dec 6, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Dec 6, 2023

This closes #240

  • Checks pass
  • No warnings in dev mode
  • Add separate build type for .css entrypoints

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit fb43c6d
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6570ac1e66dd17000835a579
😎 Deploy Preview https://deploy-preview-261--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title feat: Vite 5 support feat!: Vite 5 support Dec 6, 2023
@aklinker1
Copy link
Collaborator Author

Can't get types working while supporting vite 4 and vite 5, so I'm making this a breaking change and only supporting vite 5 for WXT 0.11+

@aklinker1 aklinker1 marked this pull request as draft December 6, 2023 05:07
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (f922648) 65.69% compared to head (fb43c6d) 70.15%.

Files Patch % Lines
src/core/builders/vite/index.ts 42.42% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   65.69%   70.15%   +4.45%     
==========================================
  Files          78      130      +52     
  Lines        5926     7247    +1321     
  Branches      469      566      +97     
==========================================
+ Hits         3893     5084    +1191     
- Misses       1997     2114     +117     
- Partials       36       49      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1
Copy link
Collaborator Author

Alright, everything is working, and the templates all work except Solid's. I've disabled it's validation for now since it's known to not work against the latest main branch, and will merge.

@aklinker1 aklinker1 marked this pull request as ready for review December 6, 2023 17:18
@aklinker1 aklinker1 merged commit 1a39a0d into main Dec 6, 2023
15 checks passed
@aklinker1 aklinker1 deleted the vite-5 branch December 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 5
1 participant