Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable SolidJS template validation #262

Closed
aklinker1 opened this issue Dec 6, 2023 · 0 comments · Fixed by #265
Closed

Re-enable SolidJS template validation #262

aklinker1 opened this issue Dec 6, 2023 · 0 comments · Fixed by #265
Labels
chore

Comments

@aklinker1
Copy link
Collaborator

aklinker1 commented Dec 6, 2023 •
edited
Loading

Chore

Template validation runs against main, and until Solid supports Vite 5, I've disabled it since it won't pass checks.

Originally from #261 (comment)

Just need to uncomment this line and upgrade the vite plugin version once Solid supports Vite 5

wxt/.github/workflows/validate.yml

Line 57 in 1a39a0d

# - solid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update sSolid template to vite 5 wxt-dev/wxt
1 participant
@aklinker1