Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update sSolid template to vite 5 #265

Merged
merged 2 commits into from
Dec 8, 2023
Merged

chore: Update sSolid template to vite 5 #265

merged 2 commits into from
Dec 8, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Dec 8, 2023

This closes #262

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 90917d8
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6572a212ec8cef0008864868
😎 Deploy Preview https://deploy-preview-265--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8786aa9) 69.99% compared to head (90917d8) 69.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   69.99%   69.99%           
=======================================
  Files         133      133           
  Lines        7338     7338           
  Branches      572      572           
=======================================
  Hits         5136     5136           
  Misses       2152     2152           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title chore: Update solid template to vite 5 chore: Update sSolid template to vite 5 Dec 8, 2023
@aklinker1 aklinker1 marked this pull request as ready for review December 8, 2023 05:05
@aklinker1 aklinker1 merged commit 59094c9 into main Dec 8, 2023
16 checks passed
@aklinker1 aklinker1 deleted the solid-validation branch December 8, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable SolidJS template validation
1 participant