add pure Haskell implementation for Windows support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Windows offers no equivalent to
wcwidth, this patch includes a pure Haskell implementation based on this python implementation. The python implementation actually generates the tables from testing based on the Unicode website, so it should be more reliable and up-to-date when compared to the native implementation. If that's the case, it may be worthwhile to allow the user to choose the Haskell implementation, though this pull request does not include that option.Obviously, the Windows implementation may behave differently from the libc implementation, but I didn't see that as a problem worth solving. Let me know if you disagree.
Tangentially, I also included a working stack.yaml which I used to compile on Windows.
I am currently using this implementation in a console application consuming and generating Chinese multibyte characters, so it appears to work well.
resolves #2