Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Fix DependencyInjectionPluginFramework in build.targets #30

Closed
wants to merge 2 commits into from

Conversation

AdCodicem
Copy link

This PR fix the following issue occurring when using the plugin in a .NET framework project :
error MSB3030: Could not copy the file "C:\Users\<username>\.nuget\packages\solidtoken.specflow.dependencyinjection\0.4.1\lib\net45\SolidToken.SpecFlow.DependencyInjection.SpecFlowPlugin.dll" because it was not found.

@AdCodicem
Copy link
Author

I created my own plugin for using Microsoft DependencyInjection with SpecFlow until I saw yours, so here is a small PR which fix an error which occured on one of my project.
I tested it locally

@mbhoek
Copy link
Member

mbhoek commented Jun 9, 2020

Thank you for your PR. This makes me realise we need tests in place for both .NET Core and .NET Framework. In order to do that, I would like to recreate the error you described.
Can I ask you what version of .NET Framework you used?

@AdCodicem
Copy link
Author

My project is in .NET framework 4.7.2 (net472)

Mutualization of Specflow reference.
Using Specflow 3.3.22-beta (only for test project) to resolve the following issue SpecFlowOSS/SpecFlow#1912
@AdCodicem
Copy link
Author

AdCodicem commented Jun 9, 2020

Hi @mbhoek,
I updated my PR to include the tests as well.
As explained in the commit comment :

I believe the tests remain relevant even with these modifications.

@mbhoek mbhoek self-requested a review June 10, 2020 07:57
@mbhoek mbhoek added the bug Something isn't working label Jun 10, 2020
@mbhoek mbhoek added this to the v1.0 milestone Jun 10, 2020
@mbhoek mbhoek closed this Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants