Initial feed registry implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/innitial-registry
branch
from
39d780e to
fab44eb
Compare
MinasMazar
reviewed
Sep 11, 2020
| @@ -0,0 +1,15 @@ | |||
| module SolidusFeeds::Feeds | |||
There was a problem hiding this comment.
Why using a module instead of a class, which can be more easily initialized?
There was a problem hiding this comment.
Because in this way we can both extend the base module directly (see SolidusFeeds.extend self) and test in isolation (see subject(:solidus_feeds)) in the spec.
MinasMazar
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP, but the general idea is there, reviews and comments about the general architecture are more than welcome!