Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples in README #25

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix examples in README #25

merged 2 commits into from
Jun 25, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jun 25, 2024

We need to wrap initializer code in a config.to_prepare block
in order to work with Zeitwerk in Rails 7.

Also the required host: argument was missing for Google Merchant Feed
generator.

Last but not least a feed can only be published if found via

SolidusFeeds.configuration.find

tvdeyen added 2 commits June 25, 2024 08:27
ActiveRecord does not work yet with sqlite3 v2 gem
We need to wrap initializer code in a `config.to_prepare` block
in order to work with Zeitwerk in Rails 7.

Also the required `host:` argument was missing for Google Merchant Feed
generator.

Last but not least a feed can only be published if found via

    SolidusFeeds.configuration.find
@tvdeyen tvdeyen changed the title Fix example in README Fix examples in README Jun 25, 2024
@tvdeyen tvdeyen requested a review from a team June 25, 2024 06:57
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kennyadsl kennyadsl merged commit 7e4e175 into master Jun 25, 2024
5 checks passed
@kennyadsl kennyadsl deleted the fix-readme branch June 25, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants