[WIP] Add a class that selects the store using requests info. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
store-selector
branch
from
6e4b519 to
adb314c
Compare
kennyadsl
changed the title
This class logic is extracted from Solidus core, which is going to be simplified a lot to avoid multiple queries at each request if solidus_multi_domain extension is not used (solidusio/solidus#1971).
kennyadsl
force-pushed
the
store-selector
branch
from
adb314c to
c3c060e
Compare
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Jun 16, 2017
This commit avoids doing 2 extra queries for every request (solidusio#1971) even when solidus store is not using solidus_multi_domain extension. This logic has now been moved to the solidus_multi_domain extension since it is needed only when multiple stores are expected (solidusio-contrib/solidus_multi_domain#67).
kennyadsl
changed the title
kennyadsl
changed the title
|
Closing this one. solidusio/solidus#2022 will implement an alternative StoreSelector class directly in core, so this is no more needed. cc @jhawthorn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class logic is extracted from Solidus core, which is going
to be simplified a lot to avoid multiple queries at each request
if solidus_multi_domain extension is not used (solidusio/solidus#1971).