Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec suite maintenance #18

Merged
merged 4 commits into from
Dec 18, 2018
Merged

Spec suite maintenance #18

merged 4 commits into from
Dec 18, 2018

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Dec 14, 2018 •
edited
Loading

This PR aims to:

  • Fix most Spree.t deprecation warnings
  • Set forgery protection to false on admin orders controller spec
  • Remove Solidus v2.2 support from Travis
  • Lock FactoryBot to v4.10 for Solidus versions lower than 2.5 for compatibility reasons

@aitbw aitbw mentioned this pull request Dec 17, 2018
Closed
jacobherrington
jacobherrington approved these changes Dec 17, 2018
View reviewed changes
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @aitbw!

@kennyadsl kennyadsl merged commit 1204e9a into solidusio-contrib:master Dec 18, 2018
@aitbw aitbw deleted the nebulab/spec_suite_maintenance branch December 18, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitbw @kennyadsl @jacobherrington