Skip to content
This repository was archived by the owner on Jul 25, 2023. It is now read-only.

Relax solidus_support dependency #53

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

kennyadsl
Copy link
Member

Also, closes #52

@cyberious
Copy link

We should get this in, the gem release is broken for my needs with errors of

expected file /Users/cyberious/repos/company_x/site/vendor/ruby/2.6.0/gems/solidus_product_feed-1.0.0/app/controllers/spree/products_controller_decorator.rb to define constant Spree::ProductsControllerDecorator

@aldesantis aldesantis merged commit 5ca0a9e into master May 16, 2020
@aldesantis aldesantis deleted the kennyadsl/relax-support branch May 16, 2020 13:43
@aldesantis
Copy link
Member

@cyberious I don't have access to release this gem, but I have pushed a couple of commits in master that should fix any compatibility issues with Zeitwerk. Try pulling the gem from GitHub and let me know how it works!

@aldesantis
Copy link
Member

@kennyadsl can we release a new version? Happy to do it if you give me access on RubyGems.

@kennyadsl
Copy link
Member Author

This gem hasn't been released in several years. I think until we have a clear policy around that we can keep using the GitHub version. I would not even know which kind of release is needed (major/minor/path) honestly.

@aldesantis
Copy link
Member

@kennyadsl asking because we need to start releasing new versions of all extensions anyway, so we need to start somewhere. 😛 Happy to try and figure out what the next version should be if you provide access to RubyGems.

@kennyadsl
Copy link
Member Author

@aldesantis Added, thanks!

@aldesantis
Copy link
Member

@cyberious I have just released 1.1.0 which should contain all the fixes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants