Merge pull request #4 from ccarruitero/admin_menu

add conditional to show reports menu tab
solidusio-contrib · Oct 16, 2019 · d973af5 · d973af5
2 parents 1cf562e + caee0b4
commit d973af5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/models/solidus_reports/configuration.rb b/app/models/solidus_reports/configuration.rb
@@ -2,7 +2,11 @@ module SolidusReports
   class Configuration < Spree::Preferences::Configuration
     REPORT_TABS ||= [:reports]
 
-    new_item = Spree::BackendConfiguration::MenuItem.new(REPORT_TABS, 'file')
+    new_item = Spree::BackendConfiguration::MenuItem.new(
+      REPORT_TABS,
+      'file',
+      condition: -> { can?(:admin, REPORT_TABS) }
+    )
     Spree::Backend::Config.menu_items << new_item
   end
 end
diff --git a/spec/features/admin/homepage_spec.rb b/spec/features/admin/homepage_spec.rb
@@ -30,7 +30,7 @@
     it 'should only display tabs fakedispatch has access to' do
       visit spree.admin_path
       expect(page).to have_link('Orders')
-      expect(page).to have_link('Reports')
+      expect(page).not_to have_link('Reports')
       expect(page).not_to have_link('Products')
       expect(page).not_to have_link('Promotions')
       expect(page).not_to have_link('Settings')