Fixes cancan validation for :reports

[memotoro]

Hello.

I have an issue with solidus_reports. The class configuration has an array for the list of tabs within this menu REPORT_TABS ||= [:reports].freeze. The cancan validation is can?(:admin, REPORT_TABS) . However, I have an admin user with only that permission applied ReportDisplay and the menu is not visible. It works for the main admin user though. If I change the cancan validation to can?(:admin, :reports) it works for both. I'm not sure if the cancan validation is wrong as it is applied to an array REPORT_TABS and not the symbol :reports ?. The rest of the solidus core permissions are against a particular class name. This is the only case where the cancan validation is against an array.

Regards

[codecov]

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files           5        5           
  Lines          68       68           
=======================================
  Hits           65       65           
  Misses          3        3

Impacted Files	Coverage Δ
app/models/solidus_reports/configuration.rb	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251d871...dcd9712. Read the comment docs.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kennyadsl]

👍 that should not be an array!