Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes solidus_extension_dev_tools to solidus_dev_support #20

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Changes solidus_extension_dev_tools to solidus_dev_support #20

merged 1 commit into from
Dec 19, 2019

Conversation

memotoro
Copy link
Contributor

Hello

I had some issues with the dependencies of this gem. I changed the solidus_extension_dev_tools references for solidus_dev_support in order to have the new tools. I know this is a recent change and I'm not sure if this gem was not updated at that time. Without this change it is not possible to run any bundle command or rake task. Regards

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #20 into master will increase coverage by 28.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #20       +/-   ##
===========================================
+ Coverage   67.34%   95.58%   +28.24%     
===========================================
  Files           8        5        -3     
  Lines          98       68       -30     
===========================================
- Hits           66       65        -1     
+ Misses         32        3       -29
Impacted Files Coverage Δ
lib/solidus_reports/factories.rb
...ators/solidus_reports/install/install_generator.rb
lib/solidus_reports/version.rb

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4a157...e3980be. Read the comment docs.

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating the name of the gem 👍

@spaghetticode spaghetticode merged commit 251d871 into solidusio-contrib:master Dec 19, 2019
@memotoro memotoro deleted the fix-solidus-dev-support-dependency branch December 20, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants