Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem to latest solidus_dev_support #99

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

nirebu
Copy link
Contributor

@nirebu nirebu commented Sep 4, 2020

This PR bumps solidus_dev_support to the latest 1.6.0 version.

Since the latest version includes also a lint_code CI pass, code style has been tweaked in a couple of files to remove some violations. All other violations have been added to a rubocop TODO file to make CI pass while not disabling individual rules.

This is a pass with the command `rubocop -A` and a minor manual tweak to
fix automatically the correctable violations.
@nirebu nirebu requested review from aldesantis and elia September 11, 2020 10:34
@elia elia merged commit dec46ea into master Oct 16, 2020
@elia elia deleted the nirebu/update-solidus-dev-support branch October 16, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants