Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for solidus 3.0 #52

Closed
wants to merge 7 commits into from

Conversation

SamuelMartini
Copy link

Prepare extension for solidus-3.0
ref #51

@jarednorman
Copy link
Member

You've probably already taken a look at this, but we use this gem on a few stores and there's some question as to how to migrate away from price_in. Our thought was that the price selector API should return a price rather than a Spree::Money object so that extensions like this one can still work.

@SamuelMartini
Copy link
Author

You've probably already taken a look at this, but we use this gem on a few stores and there's some question as to how to migrate away from price_in. Our thought was that the price selector API should return a price rather than a Spree::Money object so that extensions like this one can still work.

* [initial discussion](https://github.com/solidusio/solidus/discussions/3919)

* [PR from that](https://github.com/solidusio/solidus/pull/3925)

Hey!
Thank you for the heads up! I'll follow the PR 👍

@SamuelMartini SamuelMartini force-pushed the SamuelMartini/prepare_for_solidus-3.0 branch from 0aab6a1 to 2628619 Compare February 26, 2021 11:38
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2021
@stale stale bot closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants