Solidus 3 preparation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
requested changes
Jul 4, 2021
kennyadsl
reviewed
Jul 5, 2021
cpfergus1
force-pushed
the
solidus-3-preparation
branch
from
4b3373b to
d92e20f
Compare
cpfergus1
commented
Jul 6, 2021
cpfergus1
force-pushed
the
solidus-3-preparation
branch
6 times, most recently
from
b584b0e to
9bc979c
Compare
kennyadsl
approved these changes
Jul 20, 2021
|
@jarednorman time for a second pass? |
jarednorman
requested changes
Jul 20, 2021
cpfergus1
force-pushed
the
solidus-3-preparation
branch
from
8d7306f to
add4554
Compare
From Rails 5.2 is not possible to pass a raw string to order.
Once 2.10 is no longer supported, act as paranoid will be removed and destroy will no longer work as it previously did.
…ity gap This is required to merge the functionality of price_in and price_for_options. The functionality of finding prices changes in solidus 2.11, 3.0 and master so this function serves to work for all three for these scenarios
In Solidus 3.1, the test factory no longer appends the prices to the variant without the object being reloaded. Implemented reload to assist specs to pass.
cpfergus1
force-pushed
the
solidus-3-preparation
branch
from
add4554 to
8422bfd
Compare
The sales_price is made from an price associated with the variant. To verify that the sales_price recieved the properties of the original price, you would want to test against the original price properties. In 3.1, this test failed due to the variant having more than one price, a master price and a test set price. The previous behavior would ask for the last price, `variant.prices.last.currency`, assuming a new price was generated when it was actually pulling the master variant price which was in "USD". In tests for 3.0 and below, the first price is also the last price, which is why it never failed in the first place. Swapped to literal to avoid the error.
This commit reflects changes made by Solidus [PR #169] (solidusio/solidus_dev_support#169) When testing extensions using Solidus vesions that support the definition_file_paths, it will load the core factory first and then the ones defined in `lib/extension_name/testing_support/factories`.
Test was failing within a couple ten thousandths of a second. Increased by one second to accommodate float.
cpfergus1
force-pushed
the
solidus-3-preparation
branch
from
8422bfd to
d5f72fc
Compare
|
Thank you for your corrections @kennyadsl and @jarednorman. All current topics have been remedied and pushed. I also removed two older commits that were obsolete and cleaned up the history a little bit to be more explicit. Please let me know if I left anything out! |
The bug that this code fixed has been patched in the the latest versions of bundler and is no longer required.
cpfergus1
force-pushed
the
solidus-3-preparation
branch
from
d5f72fc to
b8033cd
Compare
jarednorman
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the extension to work with current supported versions of Solidus.
This PR satisfies #51
Discussion points:
Use of conditionals and if parameters to satisfy versioning requirements.
Other possible parameters to use for SoftDelete checks than Solidus Version