Images guide to custom sizing #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
May 14, 2021
cpfergus1
force-pushed
the
images_customize_size_defaults
branch
from
02ac39c to
957cafb
Compare
cpfergus1
force-pushed
the
images_customize_size_defaults
branch
from
7a99f56 to
3d191fc
Compare
updated location of mime type info
cpfergus1
force-pushed
the
images_customize_size_defaults
branch
from
3d191fc to
36f57a0
Compare
kennyadsl
reviewed
May 19, 2021
There was a problem hiding this comment.
Good job. I left some comments, let me know your thoughts. Also, let's not forget that this is blocked by solidusio/solidus#4062.
Added general overview at beginning of the guide Modified ActiveStorage to Active Storage Corrected upload logic explanation, image variants created before Updated section on variant defaults to provide more context for post PR4062 merge Removed reference to Amazing Store Linked to guide explaining repetitive code Copy/paste instead of "rest of code" to be more descriptive
cpfergus1
force-pushed
the
images_customize_size_defaults
branch
from
321c280 to
e9e59a1
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions on how to change image sizes in Solidus