Update image size customization docs #96
Conversation
forkata
force-pushed
the
fix/update-image-processing-guides
branch
from
43324f1 to
6d5bb3c
Compare
|
Looking great, @forkata! |
|
Thanks @waiting-for-dev! One thing I don't know is why the build preview is not working? Any ideas on this? I was hoping to preview the rendered version and copy this change to the 3.2/3.3 version of the docs as well. |
|
I think the build needs to be manually done by an admin on Cloudfare (cc @kennyadsl). For now, you can locally preview your changes following the README instructions. Let me know if you need any help. Notice there's also a script to backport to older versions easily. Again, let me know if you need support. |
forkata
force-pushed
the
fix/update-image-processing-guides
branch
from
6d5bb3c to
6a96127
Compare
|
Thanks for the help @waiting-for-dev, the local preview worked great! I made a few formatting I also added an example for how to reference the new image style if using the started frontend, let me know if that makes sense! The back-port script was a breeze to use as well, thanks for pointing me to that! I think this should be ready for some reviews. |
forkata
force-pushed
the
fix/update-image-processing-guides
branch
from
6a96127 to
b9d8ed5
Compare
We found that the documentation on customizing image sizes for products and variants was outdated and suggested users introduce a decorator. This was fixed previously in the Legacy guides and we have ported the updated documentation to the new version here. Fixes solidusio#94 Co-authored-by: Cameron Day <cameron@super.gd>
This change to the docs applies to all versions of Solidus since version 3.1 when the preferences for customizing image sizes were added solidusio/solidus#4062. Co-authored-by: Cameron Day <cameron@super.gd>
forkata
force-pushed
the
fix/update-image-processing-guides
branch
from
b9d8ed5 to
b828762
Compare
|
Thanks @forkata and @camerond594! Trying to understand if there's a way with Cloudflare to build previews coming from forks. Will keep you posted. |
|
From a Cloudflare Discord thread:
So, I guess we need to migrate to other solutions that allow PRs from forked repositories if we want to show previews for external contributions, and I guess we want. 😬 |
Summary
We found that the documentation on customizing image sizes for products and
variants was outdated and suggested users introduce a decorator. This was
fixed previously in the Legacy guides and we have ported the updated documentation
to the new version here.
Fixes #94
Checklist