Order#recalculate already updates shipment amounts

It does it in the OrderUpdater#update_shipment_amounts.
solidusio · May 10, 2019 · 0a04e8e · 0a04e8e
1 parent 1d1327e
commit 0a04e8e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rb
@@ -579,7 +579,6 @@ def shipping_eq_billing_address?
 
     # @deprecated This now happens during #recalculate
     def set_shipments_cost
-      shipments.each(&:update_amounts)
       recalculate
     end
     deprecate set_shipments_cost: :recalculate, deprecator: Spree::Deprecation

diff --git a/core/spec/models/spree/order_spec.rb b/core/spec/models/spree/order_spec.rb
@@ -181,7 +181,6 @@
     before { allow(order).to receive_messages shipments: [shipment] }
 
     it "update and persist totals" do
-      expect(shipment).to receive :update_amounts
       expect(order.updater).to receive :update
 
       Spree::Deprecation.silence do