Move handlebar templates to locals

These being set on the window is a relic of when they were compiled in JS from templates in the HTML.
solidusio · Mar 17, 2016 · 0f5c0d0 · 0f5c0d0
1 parent 652b8de
commit 0f5c0d0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/backend/app/assets/javascripts/spree/backend/line_items_on_order_edit.js b/backend/app/assets/javascripts/spree/backend/line_items_on_order_edit.js
@@ -9,6 +9,8 @@ $(document).ready(function () {
         var variant = _.find(window.variants, function(variant){
             return variant.id == variant_id
         })
+
+        var variantLineItemTemplate = HandlebarsTemplates["variants/line_items_autocomplete_stock"];
         $('#stock_details').html(variantLineItemTemplate({variant: variant}));
         $('#stock_details').show();
 

diff --git a/backend/app/assets/javascripts/spree/backend/shipments.js b/backend/app/assets/javascripts/spree/backend/shipments.js
@@ -9,6 +9,8 @@ $(document).ready(function () {
     var variant = _.find(window.variants, function(variant){
       return variant.id == variant_id
     })
+
+    var variantStockTemplate = HandlebarsTemplates["variants/autocomplete_stock"];
     $('#stock_details').html(variantStockTemplate({variant: variant}));
     $('#stock_details').show();
 

diff --git a/backend/app/assets/javascripts/spree/backend/variant_autocomplete.js.coffee b/backend/app/assets/javascripts/spree/backend/variant_autocomplete.js.coffee
@@ -1,8 +1,6 @@
 # variant autocompletion
-$(document).ready ->
-  window.variantTemplate = HandlebarsTemplates["variants/autocomplete"]
-  window.variantStockTemplate = HandlebarsTemplates["variants/autocomplete_stock"]
-  window.variantLineItemTemplate = HandlebarsTemplates["variants/line_items_autocomplete_stock"]
+
+variantTemplate = HandlebarsTemplates["variants/autocomplete"]
 
 formatVariantResult = (variant) ->
   variant.image = variant.images[0].mini_url  if variant["images"][0] isnt `undefined` and variant["images"][0].mini_url isnt `undefined`