Disable Rails/SkipsModelValidations in spec folder

It's okay to skip model validation to setup a spec.
solidusio · Oct 24, 2019 · 1ce1e4e · 1ce1e4e
1 parent 448c59a
commit 1ce1e4e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -121,6 +121,11 @@ Rails/DynamicFindBy:
     - find_by_param
     - find_by_param!
 
+# It's okay to skip model validations to setup a spec.
+Rails/SkipsModelValidations:
+  Exclude:
+    - '*/spec/**/*'
+
 # We use a lot of
 #
 #     expect {

diff --git a/core/spec/models/spree/order_updater_spec.rb b/core/spec/models/spree/order_updater_spec.rb
@@ -158,7 +158,10 @@ def create_adjustment(label, amount)
                                 amount: -500,
                                 finalized: true,
                                 label: 'Some other credit')
+
+            # rubocop:disable Rails/SkipsModelValidations
             line_item.adjustments.each { |item| item.update_column(:eligible, true) }
+            # rubocop:enable Rails/SkipsModelValidations
 
             order.recalculate