Merge pull request #3875 from BenMorganIO/improve-update-positions-pe…

…rformance eager load records instead of n+1 for update_positions
solidusio · Apr 30, 2021 · 248b39f · 248b39f
2 parents d0e27f5 + cab33db
commit 248b39f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/backend/app/controllers/spree/admin/resource_controller.rb b/backend/app/controllers/spree/admin/resource_controller.rb
@@ -78,8 +78,11 @@ def create
 
   def update_positions
     ActiveRecord::Base.transaction do
-      params[:positions].each do |id, index|
-        model_class.find_by(id: id)&.set_list_position(index)
+      positions = params[:positions]
+      records = model_class.where(id: positions.keys).to_a
+
+      positions.each do |id, index|
+        records.find { |r| r.id == id.to_i }&.set_list_position(index)
       end
     end