Merge pull request #3337 from nebulab/kennyadsl/bump-required-ruby-ve…

…rsion Bump required ruby version to 2.4
solidusio · Oct 3, 2019 · 2a6d943 · 2a6d943
2 parents 58533d2 + 699e7a4
commit 2a6d943
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 8 deletions.
diff --git a/.hound.yml b/.hound.yml
@@ -1,5 +1,6 @@
 ruby:
   config_file: .rubocop.yml
+  version: 0.72.0
 erb_lint:
   enabled: true
 scss:

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,13 +1,18 @@
 # Relaxed.Ruby.Style
 
+require:
+  - rubocop-performance
+  - rubocop-rails
+
 AllCops:
   Exclude:
     - 'vendor/**/*'
     - '**/vendor/**/*'
     - '*/spec/dummy/**/*'
     - 'sandbox/**/*'
     - '**/templates/**/*'
-  TargetRubyVersion: 2.3
+    - 'guides/node_modules/**/*'
+  TargetRubyVersion: 2.4
 
 # Sometimes I believe this reads better
 # This also causes spacing issues on multi-line fixes

diff --git a/Gemfile b/Gemfile
@@ -54,7 +54,9 @@ group :utils do
   gem 'pry'
   gem 'launchy', require: false
   gem 'i18n-tasks', '~> 0.9', require: false
-  gem 'rubocop', '~> 0.53.0', require: false
+  gem 'rubocop', '~> 0.72', require: false
+  gem 'rubocop-performance', '~> 1.4', require: false
+  gem 'rubocop-rails', '~> 2.3', require: false
   gem 'gem-release', require: false
 end
 

diff --git a/api/solidus_api.gemspec b/api/solidus_api.gemspec
@@ -18,7 +18,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version = Spree.solidus_version
 
-  gem.required_ruby_version = '>= 2.2.2'
+  gem.required_ruby_version = '>= 2.4.0'
   gem.required_rubygems_version = '>= 1.8.23'
 
   gem.add_dependency 'jbuilder', '~> 2.8'

diff --git a/backend/solidus_backend.gemspec b/backend/solidus_backend.gemspec
@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
   s.require_path = 'lib'
   s.requirements << 'none'
 
-  s.required_ruby_version = '>= 2.2.2'
+  s.required_ruby_version = '>= 2.4.0'
   s.required_rubygems_version = '>= 1.8.23'
 
   s.add_dependency 'solidus_api', s.version

diff --git a/core/solidus_core.gemspec b/core/solidus_core.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.files        = `git ls-files`.split("\n")
   s.require_path = 'lib'
 
-  s.required_ruby_version     = '>= 2.2.2'
+  s.required_ruby_version = '>= 2.4.0'
   s.required_rubygems_version = '>= 1.8.23'
 
   %w[

diff --git a/frontend/solidus_frontend.gemspec b/frontend/solidus_frontend.gemspec
@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
   s.require_path = 'lib'
   s.requirements << 'none'
 
-  s.required_ruby_version = '>= 2.2.2'
+  s.required_ruby_version = '>= 2.4.0'
   s.required_rubygems_version = '>= 1.8.23'
 
   s.add_dependency 'solidus_api', s.version

diff --git a/sample/solidus_sample.gemspec b/sample/solidus_sample.gemspec
@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
   s.require_path = 'lib'
   s.requirements << 'none'
 
-  s.required_ruby_version = '>= 2.2.2'
+  s.required_ruby_version = '>= 2.4.0'
   s.required_rubygems_version = '>= 1.8.23'
 
   s.add_dependency 'solidus_core', s.version

diff --git a/solidus.gemspec b/solidus.gemspec
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.require_path = 'lib'
   s.requirements << 'none'
 
-  s.required_ruby_version     = '>= 2.2.2'
+  s.required_ruby_version = '>= 2.4.0'
   s.required_rubygems_version = '>= 1.8.23'
 
   s.author       = 'Solidus Team'