Merge pull request #3831 from nebulab/kennyadsl/refund-perform-fix

Fix ability to perform refunds after a first failed attempt

backend/app/controllers/spree/admin/refunds_controller.rb

@@ -11,8 +11,9 @@ class RefundsController < ResourceController
       rescue_from Spree::Core::GatewayError, with: :spree_core_gateway_error
 
       def create
-        @refund.attributes = refund_params.merge(perform_after_create: false)
-        if @refund.save && @refund.perform!
+        @refund.attributes = refund_params
+
+        if @refund.valid? && @refund.perform!
           flash[:success] = flash_message_for(@refund, :successfully_created)
           respond_with(@refund) do |format|
             format.html { redirect_to location_after_save }

backend/spec/controllers/spree/admin/refunds_controller_spec.rb

@@ -42,7 +42,7 @@
     context "a Spree::Core::GatewayError is raised" do
       before do
         expect_any_instance_of(Spree::Refund).
-          to receive(:perform!).
+          to receive(:process!).
           and_raise(Spree::Core::GatewayError.new('An error has occurred'))
       end
 

core/app/models/spree/refund.rb

@@ -61,7 +61,13 @@ def perform!
       )
 
       log_entries.build(details: perform_response.to_yaml)
-      update!(transaction_id: perform_response.authorization)
+
+      self.transaction_id = perform_response.authorization
+      # This is needed otherwise set_perform_after_create_default callback
+      # will print a deprecation warning when save! creates a record.
+      self.perform_after_create = false unless persisted?
+      save!
+
       update_order
     end