Convert tiered promotion calculator buttons to anchors

Buttons block the surrounding form from being submitted by enter key. Instead the enter key leads to tiers being added. Using anchors instead.
solidusio · Jan 10, 2018 · 6162a54 · 6162a54
1 parent dac6cbd
commit 6162a54
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/backend/app/views/spree/admin/promotions/calculators/tiered_flat_rate/_fields.html.erb b/backend/app/views/spree/admin/promotions/calculators/tiered_flat_rate/_fields.html.erb
@@ -25,6 +25,6 @@
       'form-prefix' => prefix,
       'calculator' => 'tiered_flat_rate'
     } %>
-    <button class="button js-add-tier"><%= t('spree.actions.add') %></button>
+    <a class="button js-add-tier"><%= t('spree.actions.add') %></a>
   </div>
 </div>
diff --git a/backend/app/views/spree/admin/promotions/calculators/tiered_percent/_fields.html.erb b/backend/app/views/spree/admin/promotions/calculators/tiered_percent/_fields.html.erb
@@ -25,6 +25,6 @@
       'form-prefix' => prefix,
       'calculator' => 'tiered_percent'
     } %>
-    <button class="button js-add-tier"><%= t('spree.actions.add') %></button>
+    <a class="button js-add-tier"><%= t('spree.actions.add') %></a>
   </div>
 </div>
diff --git a/backend/spec/features/admin/promotions/tiered_calculator_spec.rb b/backend/spec/features/admin/promotions/tiered_calculator_spec.rb
@@ -20,7 +20,7 @@
       expect(page).to have_content("Base Percent")
       expect(page).to have_content("Tiers")
 
-      click_button "Add"
+      page.find('a.button').click
     end
 
     fill_in "Base Percent", with: 5