Merge pull request #3552 from blocknotes/blocknotes/system-specs-config

Add system specs configuration

backend/spec/spec_helper.rb

@@ -36,6 +36,8 @@
 require 'spree/testing_support/url_helpers'
 require 'spree/testing_support/order_walkthrough'
 require 'spree/testing_support/capybara_ext'
+require 'spree/testing_support/precompiled_assets'
+require 'spree/testing_support/translations'
 
 require 'capybara-screenshot/rspec'
 Capybara.save_path = ENV['CIRCLE_ARTIFACTS'] if ENV['CIRCLE_ARTIFACTS']
@@ -79,15 +81,6 @@
     DatabaseCleaner.clean_with :truncation
   end
 
-  config.when_first_matching_example_defined(type: :feature) do
-    config.before :suite do
-      # Preload assets
-      # This should avoid capybara timeouts, and avoid counting asset compilation
-      # towards the timing of the first feature spec.
-      Rails.application.precompiled_assets
-    end
-  end
-
   config.before do
     Rails.cache.clear
     if RSpec.current_example.metadata[:js] && page.driver.browser.respond_to?(:url_blacklist)
@@ -96,14 +89,7 @@
   end
 
   config.include BaseFeatureHelper, type: :feature
-
-  config.after(:each, type: :feature) do |example|
-    missing_translations = page.body.scan(/translation missing: #{I18n.locale}\.(.*?)[\s<\"&]/)
-    if missing_translations.any?
-      puts "Found missing translations: #{missing_translations.inspect}"
-      puts "In spec: #{example.location}"
-    end
-  end
+  config.include BaseFeatureHelper, type: :system
 
   config.include FactoryBot::Syntax::Methods
   config.include ActiveSupport::Testing::Assertions
@@ -113,6 +99,7 @@
   config.include Spree::TestingSupport::UrlHelpers
   config.include Spree::TestingSupport::ControllerRequests, type: :controller
   config.include Spree::TestingSupport::Flash
+  config.include Spree::TestingSupport::Translations
 
   config.extend WithModel
 

core/lib/spree/testing_support/authorization_helpers.rb

@@ -65,4 +65,5 @@ def custom_authorization!(&block)
   config.extend Spree::TestingSupport::AuthorizationHelpers::Controller, type: :controller
   config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :feature
   config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :request
+  config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
 end

core/lib/spree/testing_support/blacklist_urls.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Spree
+  module TestingSupport
+    module BlacklistUrls
+      def setup_url_blacklist(browser)
+        if browser.respond_to?(:url_blacklist)
+          browser.url_blacklist = ['http://fonts.googleapis.com']
+        end
+      end
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.before(:each, type: :feature) do
+    setup_url_blacklist(page.driver.browser)
+  end
+
+  config.before(:each, type: :system) do
+    setup_url_blacklist(page.driver.browser)
+  end
+end

core/lib/spree/testing_support/precompiled_assets.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.when_first_matching_example_defined(type: :feature) do
+    config.before :suite do
+      Rails.application.precompiled_assets
+    end
+  end
+
+  config.when_first_matching_example_defined(type: :system) do
+    config.before :suite do
+      Rails.application.precompiled_assets
+    end
+  end
+end

core/lib/spree/testing_support/translations.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Spree
+  module TestingSupport
+    module Translations
+      def check_missing_translations(page, example)
+        missing_translations = page.body.scan(/translation missing: #{I18n.locale}\.(.*?)[\s<\"&]/)
+        if missing_translations.any?
+          puts "Found missing translations: #{missing_translations.inspect}"
+          puts "In spec: #{example.location}"
+        end
+      end
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.after(:each, type: :feature) do |example|
+    check_missing_translations(page, example)
+  end
+
+  config.after(:each, type: :system) do |example|
+    check_missing_translations(page, example)
+  end
+end

frontend/spec/spec_helper.rb

@@ -36,6 +36,8 @@
 require 'spree/testing_support/url_helpers'
 require 'spree/testing_support/order_walkthrough'
 require 'spree/testing_support/caching'
+require 'spree/testing_support/blacklist_urls'
+require 'spree/testing_support/translations'
 
 require 'capybara-screenshot/rspec'
 Capybara.save_path = ENV['CIRCLE_ARTIFACTS'] if ENV['CIRCLE_ARTIFACTS']
@@ -77,26 +79,14 @@
     Rails.cache.clear
   end
 
-  config.before(:each, type: :feature) do
-    if page.driver.browser.respond_to?(:url_blacklist)
-      page.driver.browser.url_blacklist = ['http://fonts.googleapis.com']
-    end
-  end
-
-  config.after(:each, type: :feature) do |example|
-    missing_translations = page.body.scan(/translation missing: #{I18n.locale}\.(.*?)[\s<\"&]/)
-    if missing_translations.any?
-      puts "Found missing translations: #{missing_translations.inspect}"
-      puts "In spec: #{example.location}"
-    end
-  end
-
   config.include FactoryBot::Syntax::Methods
 
   config.include Spree::TestingSupport::Preferences
   config.include Spree::TestingSupport::UrlHelpers
   config.include Spree::TestingSupport::ControllerRequests, type: :controller
   config.include Spree::TestingSupport::Flash
+  config.include Spree::TestingSupport::BlacklistUrls
+  config.include Spree::TestingSupport::Translations
 
   config.example_status_persistence_file_path = "./spec/examples.txt"