Merge pull request #5143 from solidusio/elia/rubocop-missing-super

Confirm MissingSuper rubocop exceptions
solidusio · Jun 12, 2023 · 78d20c4 · 78d20c4
2 parents 0af0017 + d729957
commit 78d20c4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -334,3 +334,8 @@ Naming/MemoizedInstanceVariableName:
 
 Lint/SuppressedException:
   Enabled: false
+
+Lint/MissingSuper:
+  Exclude:
+    - 'core/lib/spree/deprecation.rb' # this is a known class that doesn't require super
+    - 'core/lib/spree/preferences/configuration.rb' # this class has no superclass defining `self.inherited`
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -243,12 +243,6 @@ Lint/EmptyConditionalBody:
   Exclude:
     - 'core/lib/spree/preferences/statically_configurable.rb'
 
-# Offense count: 2
-Lint/MissingSuper:
-  Exclude:
-    - 'core/lib/spree/deprecation.rb'
-    - 'core/lib/spree/preferences/configuration.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Lint/ParenthesesAsGroupedExpression: