Remove clear cache button from admin

Our existing "General Settings" page has a "Clear cache" button.

On stores I've worked on I wouldn't want this exposed to admins. We
should (and afaik we do) expire caches every time the underlying DB
object is changed.

This is motivated partly because I want to replace the
GeneralSettingsController with a StoreController, and this is the only
thing on that page that doesn't directly relate to a store.

CHANGELOG.md

@@ -18,6 +18,8 @@
 
 *   Remove unused `user_id` column from PromotionRule. [#1259](https://github.com/solidusio/solidus/pull/1259)
 
+*   Removed "Clear cache" button from the admin [#1275](https://github.com/solidusio/solidus/pull/1275)
+
 ## Solidus 1.3.0 (unreleased)
 
 *   Order now requires a `store_id` in validations

backend/app/assets/javascripts/spree/backend/routes.js

@@ -1,6 +1,5 @@
 Spree.routes.checkouts_api = Spree.pathFor('api/checkouts')
 Spree.routes.classifications_api = Spree.pathFor('api/classifications')
-Spree.routes.clear_cache = Spree.pathFor('admin/general_settings/clear_cache')
 Spree.routes.option_value_search = Spree.pathFor('api/option_values')
 Spree.routes.option_type_search = Spree.pathFor('api/option_types')
 Spree.routes.orders_api = Spree.pathFor('api/orders')

backend/app/controllers/spree/admin/general_settings_controller.rb

@@ -17,12 +17,6 @@ def update
         end
       end
 
-      def clear_cache
-        Rails.cache.clear
-        invoke_callbacks(:clear_cache, :after)
-        head :no_content
-      end
-
       private
 
       def store_params

backend/app/views/spree/admin/general_settings/edit.html.erb

@@ -59,22 +59,6 @@
         </div>
       <% end %>
 
-      <% if can? :clear_cache, :general_settings %>
-        <div class="row">
-          <div class="alpha six columns">
-            <fieldset class="no-border-bottom">
-              <legend align="center"><%= Spree.t(:clear_cache)%></legend>
-              <div>
-                <%= Spree.t(:clear_cache_warning) %>
-              </div>
-              <div class="field" data-hook="general_settings_clear_cache">
-                <%= button Spree.t(:clear_cache), '', 'button', id: "clear_cache" %>
-              </div>
-            </fieldset>
-          </div>
-        </div>
-      <% end %>
-
       <% if can? :update, :general_settings %>
         <div class="form-buttons filter-actions actions" data-hook="buttons">
           <%= button Spree.t('actions.update'), 'refresh' %>

backend/config/routes.rb

@@ -130,11 +130,7 @@
       end
     end
 
-    resource :general_settings, only: [:edit, :update] do
-      collection do
-        post :clear_cache
-      end
-    end
+    resource :general_settings, only: [:edit, :update]
 
     resources :return_items, only: [:update]
 

backend/spec/features/admin/configuration/general_settings_spec.rb

@@ -44,15 +44,4 @@
       expect(page).to have_field("Site Name", with: "")
     end
   end
-
-  context "clearing the cache" do
-    it "should clear the cache" do
-      expect(page).to_not have_content(Spree.t(:clear_cache_ok))
-      expect(page).to have_content(Spree.t(:clear_cache_warning))
-
-      click_button "Clear Cache"
-
-      expect(page).to have_content(Spree.t(:clear_cache_ok))
-    end
-  end
 end