Extract the loading of the taxon in a method to allow an easier overr…

…iding

Update CHANGELOG

CHANGELOG.md

@@ -4,6 +4,10 @@
 
 - The promotions "Advertise" checkbox and the "URL Path" promotion activation method have been removed from the admin UI because the features are not implemented in solidus_frontend [#2737](https://github.com/solidusio/solidus/pull/2737) ([benjaminwil](https://github.com/benjaminwil)
 
+### Frontend
+
+- The `TaxonsController#show` action loads now the `@taxon` in a `before_action` callback. This means that if you overrode the `show` method you may be loading the `@taxon` variable twice. You can now change the behaviour of how the `@taxon` is loaded overriding the `load_taxon` method instead. [#2782](https://github.com/solidusio/solidus/pull/2782) ([coorasse](https://github.com/coorasse))
+
 ## Solidus 2.6.0 (2018-05-16)
 
 ### Major changes

frontend/app/controllers/spree/taxons_controller.rb

@@ -4,19 +4,22 @@ module Spree
   class TaxonsController < Spree::StoreController
     helper 'spree/products', 'spree/taxon_filters'
 
+    before_action :load_taxon, only: [:show]
+
     respond_to :html
 
     def show
-      @taxon = Spree::Taxon.find_by!(permalink: params[:id])
-      return unless @taxon
-
       @searcher = build_searcher(params.merge(taxon: @taxon.id, include_images: true))
       @products = @searcher.retrieve_products
       @taxonomies = Spree::Taxonomy.includes(root: :children)
     end
 
     private
 
+    def load_taxon
+      @taxon = Spree::Taxon.find_by!(permalink: params[:id])
+    end
+
     def accurate_title
       if @taxon
         @taxon.seo_title