-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only default to activestorage adapter if Rails version is supported
We only support the activestorage adapter with Rails 6.1 and above, but we default to it, even if the Rails version is 6.0 and below. Since we still support Rails 5.2 and 6.0, we cannot default to the active storage adapter. The app won't boot unless we also change the adapter in the spree initializer. If the initializer, though, is nested in a `config.to_prepare` hook (as recommended from Rails new autoloader zeitwerk [1]) the app refuses to start anyhow, because the config is then taken from the `app_configuration` defaults. [1](https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#use-case-1-during-boot-load-reloadable-code)
Showing
2 changed files
with
27 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters