Merge pull request #2592 from jhawthorn/button_frozen_string

Avoid frozen string error in button helper
solidusio · Feb 22, 2018 · bf7831f · bf7831f
2 parents dddf5a8 + d861ea5
commit bf7831f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/backend/app/helpers/spree/admin/navigation_helper.rb b/backend/app/helpers/spree/admin/navigation_helper.rb
@@ -130,7 +130,7 @@ def button(text, icon_name = nil, button_type = 'submit', options = {})
         class_names = "button"
         if icon_name
           Spree::Deprecation.warn "Using icon_name arg is deprecated. Icons could not be visible in future versions.", caller
-          class_names.prepend "fa fa-#{icon_name} "
+          class_names = "fa fa-#{icon_name} #{class_names}"
         end
         button_tag(text, options.merge(type: button_type, class: class_names))
       end