Remove Deprecated Email Validator

The email validator was deprecated Mar 15th 2018 almost 18 months ago as part of: 6d8fd3c The deprecation warning was part of v2.6.0rc1, and remains to this day in v2.10.0.beta1 I think it's time to remove it altogether. It's been 4 minor version upgrades now.
solidusio · Oct 23, 2019 · c0f3105 · c0f3105
1 parent 7363581
commit c0f3105
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 85 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## Solidus 2.10.0 (master, unreleased)
 
+### Core
+
+- Removes Deprecated EmailValidator [#3395](https://github.com/solidusio/solidus/pull/3395) ([JDutil](https://github.com/JDutil))
+
 ## Solidus 2.9.0 (2019-07-16)
 
 ### Major Changes

diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rb
@@ -122,7 +122,6 @@ def states
     before_create :link_by_email
 
     validates :email, presence: true, if: :require_email
-    validates :email, 'spree/email' => true, allow_blank: true
     validates :guest_token, presence: { allow_nil: true }
     validates :number, presence: true, uniqueness: { allow_blank: true }
     validates :store_id, presence: true

diff --git a/core/lib/spree/core.rb b/core/lib/spree/core.rb
@@ -98,7 +98,6 @@ class GatewayError < RuntimeError; end
 require 'spree/core/role_configuration'
 require 'spree/core/state_machines'
 require 'spree/core/stock_configuration'
-require 'spree/core/validators/email'
 require 'spree/permission_sets'
 
 require 'spree/preferences/store'

diff --git a/core/lib/spree/core/validators/email.rb b/core/lib/spree/core/validators/email.rb
diff --git a/core/spec/lib/spree/core/validators/email_spec.rb b/core/spec/lib/spree/core/validators/email_spec.rb