always return something from filter function

solidusio · Apr 20, 2020 · d898c02 · d898c02
1 parent 8dc58a8
commit d898c02
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js b/backend/app/assets/javascripts/spree/backend/views/order/details_adjustments.js
@@ -10,11 +10,7 @@ Spree.Views.Order.DetailsAdjustments = Backbone.View.extend({
     collection
       .map(function(item) {
         return (item.get("adjustments") || [])
-          .filter(function(adjustment) {
-            if (adjustment.eligible === true) {
-              return adjustment;
-            }
-          });
+          .filter(function(adjustment) { return (adjustment.eligible === true); });
       })
       .flatten(true)
       .each(function(adjustment){