Do not consider unpromotionable line items discountable

solidusio · Mar 21, 2022 · e341f09 · e341f09
1 parent 6290769
commit e341f09
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/app/models/spree/promotion.rb b/core/app/models/spree/promotion.rb
@@ -254,7 +254,8 @@ def order_discountable?(order)
     end
 
     def line_item_discountable?(line_item)
-      rules.all? { |rule| rule.line_item_discountable?(line_item) }
+      line_item.variant.product.promotionable? &&
+        rules.all? { |rule| rule.line_item_discountable?(line_item) }
     end
 
     def shipment_discountable?(shipment)