Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spree::Admin::VariantsController#index breaks for deleted products #1803

Closed
bbuchalter opened this issue Mar 28, 2017 · 0 comments
Closed

Spree::Admin::VariantsController#index breaks for deleted products #1803

bbuchalter opened this issue Mar 28, 2017 · 0 comments

Comments

@bbuchalter
Copy link
Contributor

Steps to reproduce

chruby 2.4
git clone https://github.com/solidusio/solidus.git
cd solidus
bundle
bundle exec rake sandbox
cd sandbox
bin/rails s

Expected behavior

I should see the variants for the product

Actual behavior

NoMethodError (undefined method `variants' for nil:NilClass):

/Users/brian/workspace/solidus_master/backend/app/controllers/spree/admin/resource_controller.rb:189:in `collection'
/Users/brian/workspace/solidus_master/backend/app/controllers/spree/admin/variants_controller.rb:40:in `collection'
/Users/brian/workspace/solidus_master/backend/app/controllers/spree/admin/resource_controller.rb:144:in `load_resource'

System configuration

Solidus Version: master

Extensions in use: none

bbuchalter added a commit to bbuchalter/solidus that referenced this issue Apr 19, 2017
Per issue solidusio#1803 deleted
products could not show their variants due to a missing `with_deleted`
scope on `ResourceController#parent`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant