Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of the promotion seperator #1946

Closed
ericgross opened this issue May 23, 2017 · 2 comments · Fixed by #2662
Closed

Allow customization of the promotion seperator #1946

ericgross opened this issue May 23, 2017 · 2 comments · Fixed by #2662

Comments

@ericgross
Copy link
Contributor

Rather than always separating the promotion base with an underscore, allow the character to be changed without opening up the class.
@vladstoick vladstoick mentioned this issue May 23, 2017
Closed
vladstoick added a commit to vladstoick/solidus that referenced this issue May 23, 2017
@vladstoick
Allow custom join charachter separator for promotion
f2d5af4 
Implements solidusio#1946 by setting a class variable that for the join_character that connects the base code with the suffix in the code creation process
@bbuchalter
Copy link
Contributor

I just got a comment from my marketing team about making changes to this. 👍

Extra points if it's administerable.

@jhawthorn
Copy link
Contributor

As the BatchBuilder can now take options, maybe we can store a desired separator value on PromotionCodeBatch and pass it in when running the BatchBuilder from PromotionCodeBatchJob

@gevann gevann mentioned this issue Mar 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promo code batch join chars gevann/solidus
4 participants
@jhawthorn @ericgross @bbuchalter @mamhoff